Remove exception when multi_field type is used #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to this, it was working fine before the commit 62b28a8. |
richardmiller-zz
added a commit
that referenced
this pull request
Nov 30, 2012
Remove exception when multi_field type is used
|
Thanks, if it works fine as is then there is no need for this exception. Anyone needing custom transformations can still implement them. |
makasim
added a commit
to formapro-forks/FOSElasticaBundle
that referenced
this pull request
Jul 17, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When the nested object functionality was recently merged,
Transformer/ModelToElasticaAutoTransformer.php's behaviour was changed to throw an exception if the field type ismulti_field.Multi-field mapping seemed to be working for me, so I'm not sure why this was necessary? It's quite possible I'm missing something, but if the functionality is missing, surely it's better to not do anything at all? Based on that opinion, I've removed the Exception.
Cheers,
Craig