Allow serialize_null option for Serializer #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -583,6 +583,8 @@ protected function getSerializerNode() | |||
| ->prototype('scalar')->end() | |||
| ->end() | |||
| ->scalarNode('version')->end() | |||
| ->booleanNode('serialize_null') | |||
| ->defaultFalse() | |||
There was a problem hiding this comment.
That was fast @stloyd, thanks!
It is fixed now.
michaelperrin
force-pushed
the
feature/serialize_null
branch
from
fe86adf
to
2b1ee49
Compare
|
Please add test coverage for this change |
michaelperrin
force-pushed
the
feature/serialize_null
branch
4 times, most recently
from
553e6ac
to
a299778
Compare
michaelperrin
force-pushed
the
feature/serialize_null
branch
from
a299778
to
1c886d4
Compare
|
Hi @merk, I added the needed tests. I make sure that |
|
Hello, any news on this PR please? |
XWB
added a commit
that referenced
this pull request
Mar 1, 2016
Allow serialize_null option for Serializer
|
Thanks. |
|
Thanks @XWB ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently impossible to populate attributes with a
nullvalue with FOSElasticaBundle, due to to the default behavior of JMS Serializer which doesn't serialize attributes withnullvalues.This PR adds an option to the
serializerconfiguration so that the JMS Serializer can be configured with theserialize_nulloption.There is no specific test for this PR, as it is a configuration for JMS Serializer, and I didn't find any other test concerning its configuration (for the
versionandgroupsoptions). I just updated the default test configuration (with afalsevalue, which is the default value anyway), and added an example to the documentation for better clarity.