Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple fixing of the bug adding the property store:true #987

Closed
wants to merge 2 commits into from

Conversation

mappedinn
Copy link

Hi,

This PR fixes the bug of the issue #985 that adds for each property "store": true by simply commenting the code in charge of it in Index/MappingBuilder.php.

@merk
Copy link
Member

merk commented Jan 7, 2016

I'll be pushing a commit shortly that removes setting store:true by default, which negates the need for this change.

@merk merk closed this Jan 7, 2016
@ngeleedst
Copy link

Is their any news about this fix. Because now i cannot populate because it's adding store: true to a type: object etc.. and this is not allowed!
Maybe a simple fix like, is already enough:
if (!isset($property['store']) && $property == 'string') {
$property['store'] = true;
}

@ngeleedst
Copy link

Or wait maybe just by adding: $skipTypes = array('completion','nested','object');
Shall i do a pull request with the new type 'object' added to the skypTypes?

@ngeleedst
Copy link

I did a new pull request regarding this ticket. See: #1013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants