Add a list of default matched status code #229
Conversation
| @@ -128,8 +128,11 @@ regular expressions. | |||
|
|
|||
| **type**: ``array`` | |||
|
|
|||
| A list of additional HTTP status codes of the response for which to also apply | |||
| the rule. | |||
| By defaut, a rule will only match cacheable status codes: 200, 203, 300, 301, | |||
There was a problem hiding this comment.
can you please link "cacheable status codes" to http://tools.ietf.org/html/rfc7231#page-48 ?
There was a problem hiding this comment.
oh, and travis noted that you have a spelling error: s/defaut/default/
There was a problem hiding this comment.
In that RFC, the list is longer: ‘e.g., 200, 203, 204, 206, 300, 301, 404, 405, 410, 414, and 501 in this specification’. Should we adhere to the RFC and cache those status code by default, too? So including 204 that caused confusion in #224.
There was a problem hiding this comment.
oh, indeed rfc2616 was more restrictive: http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.4
lets increase the default list but also fix the behaviour that invalidation is possible on any status < 400.
|
Merging this, as it correctly reflects the current situation. Let’s discuss the configurability and up-to-date status codes (for RFC 7231) in #69. |
Add a list of default matched status code
|
Thanks @tgalopin! |
I think it's not very clear for the moment what status code are matched by a rule. I propose to add the list in the documentation, to avoid other problems like #224 (comment).