Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a list of default matched status code #229

Merged
merged 2 commits into from Jul 5, 2015
Merged

Add a list of default matched status code #229

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58ce894
Add a list of default matched status code
tgalopin Jul 3, 2015
e4f8285
Fix typo and add link to RFC in documentation on match
tgalopin Jul 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions Resources/doc/reference/configuration/match.rst
View file
Open in desktop
Expand Up @@ -128,8 +128,11 @@ regular expressions.

**type**: ``array``

A list of additional HTTP status codes of the response for which to also apply
the rule.
By defaut, a rule will only match cacheable status codes: 200, 203, 300, 301,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please link "cacheable status codes" to http://tools.ietf.org/html/rfc7231#page-48 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, and travis noted that you have a spelling error: s/defaut/default/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that RFC, the list is longer: ‘e.g., 200, 203, 204, 206, 300, 301, 404, 405, 410, 414, and 501 in this specification’. Should we adhere to the RFC and cache those status code by default, too? So including 204 that caused confusion in #224.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, indeed rfc2616 was more restrictive: http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.4

lets increase the default list but also fix the behaviour that invalidation is possible on any status < 400.

302, 404 and 410.

`additional_cacheable_status` let you define a list of additional HTTP
status codes of the response for which to also apply the rule.

.. code-block:: yaml

Expand Down