update to use 2.0 of FOSHttpCache #235

dbu · 2015-07-31T15:32:57Z

Updating to FOSHttpCache 2.0
Starting 2.0 development
Adjust documentation for support of custom ttl in the library.

TODO

We need something to configure the http client: https://github.com/php-http/HttplugBundle/
figure out configuration for http clients in the proxy clients

ddeboer · 2015-08-02T13:03:48Z

FriendsOfSymfony/FOSHttpCache#214 has been merged, so we can merge this, too. I think we need to update the http-cache requirement to @dev, here.

dbu · 2015-08-03T06:24:48Z

right. updated - but we should first merge the bugfix #236 and then tag a last 1.3 version. this PR will start the 2.0 version of the bundle.

dbu · 2015-08-21T12:58:57Z

created the 1.3 branch, now getting serious :-)

lots of question still, however. mainly how to handle the http client... maybe a default service with a configured class if the user specifies neither class nor service?

dbu · 2015-08-21T12:59:24Z

.travis.yml


 before_script:
  - sh -c 'if [ "$SYMFONY_VERSION" != "" ]; then composer require --dev --no-update symfony/symfony=$SYMFONY_VERSION; fi;'
  - sh -c 'if [ "$FRAMEWORK_EXTRA_VERSION" != "" ]; then composer require --dev --no-update sensio/framework-extra-bundle=$FRAMEWORK_EXTRA_VERSION; fi;'
-  - composer install
+  - if [[ "$TRAVIS_PHP_VERSION" == "5.4" || "$TRAVIS_PHP_VERSION" == "hhvm" ]]; then composer remove "php-http/guzzle6-adapter" --dev --no-update; fi
+  - if [[ "$TRAVIS_PHP_VERSION" == "5.4" || "$TRAVIS_PHP_VERSION" == "hhvm" ]]; then composer require "php-http/guzzle5-adapter" --dev --no-update; fi


as in FOSHttpCache 2.0

ddeboer · 2016-11-21T12:08:06Z

As we tagged FOSHttpCache 2.0-alpha1, it would be a good time to update the bundle to work with 2.0 so users can test both in tandem. @dbu Do you have some time to resolve the merge conflicts?

We need something to configure the http client: https://github.com/php-http/HttplugBundle/

In the library, we do most of the configuration on HttpDispatcher, which wraps the Httplug client; not on Httplug itself. So while I’m okay with adding HttplugBundle as a dependency for users that want to tweak the underlying Httplug client’s settings (such as timeouts etc.), I’m not sure all users need the extra bundle. For most, being able to choose your own HTTP client adapter plus the configuration options that we already have should be sufficient.

dbu · 2016-11-21T12:23:07Z

As we tagged FOSHttpCache 2.0-alpha1, it would be a good time to update
the bundle to work with 2.0 so users can test both in tandem. @dbu
https://github.com/dbu Do you have some time to resolve the merge
conflicts?

yep, agree. will try to find some time.

We need something to configure the http client:
https://github.com/php-http/HttplugBundle/
In the library, we do most of the configuration on HttpDispatcher
http://foshttpcache.readthedocs.io/en/2.0.0-alpha1/proxy-clients.html#basic-http-setup-with-httpdispatcher,
which wraps the Httplug client; not on Httplug itself. So while I’m okay
with adding HttplugBundle as a dependency for users that want to tweak
the underlying Httplug client’s settings (such as timeouts etc.), I’m
not sure all users need the extra bundle. For most, being able to choose
your own HTTP client adapter plus the configuration options that we
already have should be sufficient.

i will have a look again at that. but i don't want to duplicate
configuration, maybe say by default we use autodiscovery otherwise
specify a http client service. and to get the service, configure
HttplugBundle or do your own thing.

dbu · 2016-11-24T18:16:12Z

Tests/Unit/CacheManagerTest.php

@@ -88,6 +88,7 @@ public function testRefreshRoute()
     */
    public function testTagResponse()
    {
+        $this->markTestSkipped('TODO refactor to use tag handler');


needs to be adjusted

ddeboer · 2016-12-01T13:10:15Z

maybe say by default we use autodiscovery otherwise
specify a http client service. and to get the service, configure
HttplugBundle or do your own thing.

I like this approach: let’s suggest HttplugBundle (it’s good bundle 😉) but leave it open for users to configure the service any way they like. FOSHttpCacheBundle then only needs the service id.

dbu · 2016-12-04T05:03:24Z

CHANGELOG.md

+
+* [Test] Dropped the proxy client services as they where not used anywhere. The
+  services `fos_http_cache.test.client.varnish` and `fos_http_cache.test.client.nginx`
+  no longer exist.


@ddeboer can you agree with this? i feel that with httplug and discovery, its easy enough to do this now on your own in tests.

dbu · 2016-12-04T05:07:19Z

DependencyInjection/Configuration.php

+                    ->info('Default host name and optional path for path based invalidation.')
+                ->end()
+                ->scalarNode('http_client')
+                    ->defaultNull()


we don't need any reference to the httplug-bundle. by default, we pass no client to HttpDispatcher, which will prompt that to do a discovery. if discovery is not desired, a client can be configured.

dbu · 2016-12-04T05:16:22Z

imho this is ready to merge now. there is a bunch of things we should clean up in this bundle, but i think we should not do that in the same PR. would prefer to merge this ASAP and then do the other things in separate PRs.

ddeboer · 2016-12-04T11:17:30Z

Ok, fixed the docs build, so almost green. There’s a dep problem on prefer-lowest, do you have an idea?

dbu · 2016-12-05T23:20:47Z

.travis.yml

+#    - php: 5.5
+#      env:
+#        - COMPOSER_FLAGS="--prefer-lowest"
+#        - SYMFONY_VERSION='2.8.*'


jordi thinks we hit some hard to tell edge case: https://twitter.com/seldaek/status/805698883456270336

i comment this build out for now and try again when we released the library

lsmith77 added the wip/poc label Jul 31, 2015

dbu force-pushed the update-2-0 branch from 0284309 to e089f51 Compare August 3, 2015 06:23

dbu force-pushed the update-2-0 branch 2 times, most recently from 4100017 to ffd6b9f Compare August 21, 2015 08:07

dbu reviewed Aug 21, 2015
View reviewed changes

dbu force-pushed the update-2-0 branch from 28e1bfe to b7b9aa9 Compare August 21, 2015 13:12

dbu mentioned this pull request Sep 30, 2015

Remove inline C from bundle docs (moved to library) #240

Closed

ddeboer mentioned this pull request Nov 15, 2015

Update inline C #219

Closed

lsmith77 removed the wip/poc label Nov 18, 2015

dbu mentioned this pull request Dec 4, 2015

Test against Symfony 3.0 #255

Closed

dbu force-pushed the update-2-0 branch from b7b9aa9 to e64c088 Compare December 9, 2015 21:50

dbu mentioned this pull request Dec 22, 2015

Call to undefined method ...CacheManager::addSubscriber() #260

Closed

dbu changed the title ~~[WIP] update for ttl support in the library~~ [WIP] update to use 2.0 of FOSHttpCache Jul 1, 2016

dbu mentioned this pull request Nov 24, 2016

cleanup event listener naming #319

Merged

dbu force-pushed the update-2-0 branch from e64c088 to f996d78 Compare November 24, 2016 18:11

dbu commented Nov 24, 2016

View reviewed changes

dbu changed the title ~~[WIP] update to use 2.0 of FOSHttpCache~~ update to use 2.0 of FOSHttpCache Dec 4, 2016

dbu commented Dec 4, 2016

View reviewed changes

update for ttl support in the library

376417d

dbu force-pushed the update-2-0 branch from a790c10 to adbb4a4 Compare December 4, 2016 05:14

dbu mentioned this pull request Dec 4, 2016

we need stdlib.h for the reverse-proxy-ttl handling #322

Merged

ddeboer force-pushed the update-2-0 branch 2 times, most recently from 49c6757 to d629ef7 Compare December 4, 2016 11:04

dbu added 2 commits December 6, 2016 00:18

adjust to library 2.0 and new setup with php-http

ae107ea

skip build-lowest for now

8614a28

dbu force-pushed the update-2-0 branch from 8ff9597 to 8614a28 Compare December 5, 2016 23:19

dbu commented Dec 5, 2016

View reviewed changes

dbu mentioned this pull request Dec 5, 2016

fix lowest build on travis #328

Closed

dbu merged commit ea4d715 into master Dec 5, 2016

dbu deleted the update-2-0 branch December 5, 2016 23:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update to use 2.0 of FOSHttpCache #235

update to use 2.0 of FOSHttpCache #235

dbu commented Jul 31, 2015 •

edited

Loading

ddeboer commented Aug 2, 2015

dbu commented Aug 3, 2015

dbu commented Aug 21, 2015

dbu Aug 21, 2015

ddeboer commented Nov 21, 2016

dbu commented Nov 21, 2016

dbu Nov 24, 2016

ddeboer commented Dec 1, 2016

dbu Dec 4, 2016

ddeboer Dec 4, 2016

dbu Dec 4, 2016

dbu commented Dec 4, 2016

ddeboer commented Dec 4, 2016

dbu Dec 5, 2016

update to use 2.0 of FOSHttpCache #235

update to use 2.0 of FOSHttpCache #235

Conversation

dbu commented Jul 31, 2015 • edited Loading

ddeboer commented Aug 2, 2015

dbu commented Aug 3, 2015

dbu commented Aug 21, 2015

dbu Aug 21, 2015

Choose a reason for hiding this comment

ddeboer commented Nov 21, 2016

dbu commented Nov 21, 2016

dbu Nov 24, 2016

Choose a reason for hiding this comment

ddeboer commented Dec 1, 2016

dbu Dec 4, 2016

Choose a reason for hiding this comment

ddeboer Dec 4, 2016

Choose a reason for hiding this comment

dbu Dec 4, 2016

Choose a reason for hiding this comment

dbu commented Dec 4, 2016

ddeboer commented Dec 4, 2016

dbu Dec 5, 2016

Choose a reason for hiding this comment

dbu commented Jul 31, 2015 •

edited

Loading