Refactor UserContextListener to take options array #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeboer
force-pushed
the
user-context-listener-options-resolver
branch
from
d27c6e8
to
184169c
Compare
dbu
approved these changes
Feb 13, 2017
| 'user_identifier_headers' => $config['user_identifier_headers'], | ||
| 'user_hash_header' => $config['user_hash_header'], | ||
| 'ttl' => $config['hash_cache_ttl'], | ||
| 'add_vary_on_hash' => $config['always_vary_on_context_hash'], |
There was a problem hiding this comment.
i just notice that this means we never actually use the defaults defined in the options, but the ones from the Configuration class. we could change the configuration to NULL, and built the options array to only hold those values that are not null... but this is independent of this refactoring.
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #352.