Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vendors #532

Closed
wants to merge 1 commit into from
Closed

Bump vendors #532

wants to merge 1 commit into from

Conversation

XWB
Copy link
Member

@XWB XWB commented Nov 27, 2019

Symfony 3.3 and 4.0 have been deprecated a long time ago.

@XWB XWB requested a review from dbu November 27, 2019 12:01
@dbu
Copy link
Contributor

dbu commented Nov 27, 2019

i think you worked on an outdated branch, master already is on 3.4 || 4, see https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/blob/master/composer.json#L26

i agree that we don't necessarily need to support non-maintained versions, but i don't want to drop 4.0-4.2 support unless there turn out to be problems or work arounds required. as long as we support 3.4 anyways, we do need some legacy BC logic.

i am currently trying out a symfony 5 build, will push a PR soon.

@XWB
Copy link
Member Author

XWB commented Nov 27, 2019

I understand. The reason for this change was the CVE alert for this repository:

image

To get rid of it, Symfony 4.0 must be dropped.

image

@dbu
Copy link
Contributor

dbu commented Nov 27, 2019

ah, okay. i will bump to ^4.1.12 then. #533 is about to get ready - if you have some time to review the :puke: i had to do to run with both symfony 4 and 5, please do ;-)

@dbu dbu mentioned this pull request Nov 27, 2019
@dbu dbu closed this in #533 Nov 28, 2019
@XWB XWB deleted the bump-vendors branch November 28, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants