symfony 5 compatibility #533
Conversation
dbu
force-pushed
the
symfony-5
branch
2 times, most recently
from
dd126e8
to
8cb65cd
Compare
dbu
force-pushed
the
symfony-5
branch
2 times, most recently
from
f247de9
to
e35610d
Compare
|
hm, does anyone have an idea what is going on with the lowest version build here? why is the class loader not finding classes? i verified that the 3.4.5 file exists and contains the expected class (even bumped from 3.4.4 to be sure its not a cached broken archive or something) |
|
@dbu because |
|
uh, that is rather implicit. thanks for pointing it out. that was the problem, had to add some dependencies. weird, that. security-bundle says it depends on those, not sure why they did not install. do you think its ok to merge like this? i don't want to add them to |
|
not in 3.4 branch which is installed with prefered-lowest https://github.com/symfony/symfony/blob/3.4/src/Symfony/Bundle/SecurityBundle/composer.json |
| @@ -60,7 +62,8 @@ matrix: | |||
| before_install: | |||
| - if [[ $COVERAGE != true ]]; then phpenv config-rm xdebug.ini || true; fi | |||
| - if ! [ -z "$STABILITY" ]; then composer config minimum-stability ${STABILITY}; fi; | |||
| - if ! [ -v "$DEPENDENCIES" ]; then composer require --no-update ${DEPENDENCIES}; fi; | |||
| - if ! [ -z "$DEPENDENCIES" ]; then composer require --no-update ${DEPENDENCIES}; fi; | |||
|
yeah i was looking at require-dev at https://packagist.org/packages/symfony/security-bundle#v3.4.4 🤦♂️ |
fix #532