Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symfony 6.3 return type deprecations #591

Merged
merged 1 commit into from
May 23, 2023

Conversation

acrobat
Copy link
Contributor

@acrobat acrobat commented May 20, 2023

Method "Symfony\Component\DependencyInjection\Extension\ExtensionInterface::load()" might add "void" as a native return type declaration in the future. Do the same in implementation "FOS\HttpCacheBundle\DependencyInjection\FOSHttpCacheExtension" now to avoid errors or add an explicit @return annotation to suppress this message.

(For all compiler passes)

Method "Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()" might add "void" as a native return type declaration in the future. Do the same in implementation "FOS\HttpCacheBundle\DependencyInjection\Compiler\LoggerPass" now to avoid errors or add an explicit @return annotation to suppress this message.

User Deprecated: Method "Symfony\Component\HttpKernel\Bundle\Bundle::build()" might add "void" as a native return type declaration in the future. Do the same in child class "FOS\HttpCacheBundle\FOSHttpCacheBundle" now to avoid errors or add an explicit @return annotation to suppress this message.

@acrobat acrobat force-pushed the fix-symfony63-deprecations branch from 24ea638 to e497544 Compare May 20, 2023 11:29
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

as the compiler passes of this bundle are not meant as extension points, i would prefer to add the actual : void return type declaration to the classes directly instead of the annotations. can you change it to that please?

@acrobat acrobat force-pushed the fix-symfony63-deprecations branch from e497544 to 2b65114 Compare May 23, 2023 06:46
@acrobat acrobat force-pushed the fix-symfony63-deprecations branch from 2b65114 to 7c88995 Compare May 23, 2023 06:46
@acrobat
Copy link
Contributor Author

acrobat commented May 23, 2023

@dbu sure, done!

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@dbu dbu merged commit faa0f08 into FriendsOfSymfony:2.x May 23, 2023
@acrobat acrobat deleted the fix-symfony63-deprecations branch May 23, 2023 06:54
@dbu
Copy link
Contributor

dbu commented May 23, 2023

https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/releases/tag/2.16.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants