remove annotation for 3.X release

[toxicity1985]

Hello,

Sorry about the mess but i make something wrong with the rebase and drop the commit.
I update the plugin yesterday. I add a match function as asked.
I juste have a question regards the invalidation path attribute. If we have a match we have to clear the path configured inside the attribute but not the route called ?

[dbu]

If we have a match we have to clear the path configured inside the attribute but not the route called ?

yes. the assumption is that you annotate this on a route that changes content (so usually it will be a POST request). if the request that triggers the invalidation would itself be cached, symfony would not be invoked on a cache hit and the invalidation would not be triggered.

[dbu]

i think we don't need this anymore

[dbu]

thanks. looks like the CI is now reporting properly again. ignore the installation problem with jean-beru for now.

the failing tests in the other builds indicate that something is not yet working properly with the attributes. or the fixtures only have annotations not attributes?

[dbu]

@toxicity1985 do you have time to check why the build fails?

[toxicity1985]

Hello,

I will check today or tommorow. I was busy last week :-p

[dbu]

thanks - did not want to rush you, just to check if it went under or if you are still aware of it.

[toxicity1985]

I fixed some test but the last are related to the cache maybe something related to configuration but i don't find where.

[toxicity1985]

@dbu i fixed the last test.

[usu]

Hi @dbu & @toxicity1985. Is there anything than could be supported to test or to fix any of the remaining tests? Or is this ready to be merged?

[toxicity1985]

Hello @usu,
I think it's ok. I use the fork version on my project.
But i think we also have to update some parent library.

[dbu]

sorry for the silence. i hope i can release 3.x soon.

there is an open comment still, and some issues with the ci.

(codestyle and readthedocs is out of scope, we can ignore those. but the phpunit builds should all be green)

[toxicity1985]

I have to fix the style. But all the test pass now.

[dbu]

is this replacing something else?

[toxicity1985]

Yes,, something used in the framework bundle.

[dbu]

thanks a lot! i wrapped this up in #611

there are still a couple of things left in the version 3 milestone https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/milestone/6