remove annotation for 3.x release #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove obsolete annotation support * document attributes * drop support for old php versions * adjust dependencies * fix codestyle
dbu
commented
Mar 20, 2024
src/Security/ExpressionLanguage.php
Outdated
| * | ||
| * @author Fabien Potencier <fabien@symfony.com> | ||
| */ | ||
| class ExpressionLanguage extends BaseExpressionLanguage |
There was a problem hiding this comment.
see discussion at #610 (comment)
i don't think this should be in the FOSHttpCacheBundle, it has nothing directly to do with it.
and reading https://symfony.com/doc/current/security/expressions.html i would expect those expressions to be supported by core symfony. can we remove it?
There was a problem hiding this comment.
asked in symfony slack if there is any service we can use to get the "full" expression language of the application
There was a problem hiding this comment.
went with allowing a custom service and defaulting to the symfony/expression-language default implementation.
dbu
commented
Mar 20, 2024
dbu
force-pushed
the
remove-sf-bundle
branch
3 times, most recently
from
4347b53
to
f847098
Compare
This was referenced Mar 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #610