[WIP] Refactoring

[leek]

Done:

• Added default controller for /authorize
• Added missing RefreshToken.mongodb.xml
• Made configuration naming/style match other FOS bundles
• Started CouchDB support

Todo:

• Update unit tests They already pass? Must not be thorough yet...
• Update documentation
• Add some better examples
• Maybe(?) add some edits to Configuration/FOSOAuthServerExtension to prevent BC breaks

Still highly work in progress, but I'd love thoughts/suggestions/criticisms/etc.

Fixes #22, #23, #7, #19

[stof]

@leek There is already a complete refactoring in the bundle in the refactoring branch (not yet completed but @schmittjoh does not have much time for it right now and so is searching someone to help finish it) so we won't do another parallel refactoring

[leek]

@stof I've seen the branch you're referring to and it is extremely (3 months) behind master in terms of time and features:

• The unit tests currently fail.
• It only supports Doctrine ORM.
• It does not have the recent addition of refresh tokens.
• It also has unnecessary dependencies on JMSSecurityExtraBundle and JMSDiExtraBundle.

[stof]

@leek the refactoring has been started by @schmittjoh and then stayed pending because of missing time. And it is intended to become the only maintained version of the FOS bundle in the future (the current version is approximately @arnaud-lb's original bundle). So a better way to invest time would be to contact @schmittjoh to help on the refactoring instead of working on another one

[leek]

@stof Well this version is basically done and has everything on the ToDo list completed.
Personally, I do not want extra unnecessary dependencies.

For anyone who wants a fully functioning OAuth 2.0 bundle (at least until @schmittjoh is done with his branch), I will be maintaining a fork under my namespace here: LeekOAuthServerBundle

[willdurand]

I think we should consider this PR really important, as there is anything else anyway...

Related discussion: #26

@leek are you still ok to merge your work to the FOSOAuthBundle, as soon as things move?

[leek]

@willdurand Sure. I haven't updated my fork recently but my local version has a few other additions like a base skeleton for requesting a clientId, allowing users to de-authorize a clientId, etc.

/cc #26

[willdurand]

@leek ok so, I agree you to continue your refactoring here. You should look at the refactoring branch, some stuffs are fine like:

• 0fa0587

and, maybe:

• 37d4847

I agree with you, we don't need any other dependencies.

[willdurand]

@leek any news?

[willdurand]

Merged.

Thank you so much @leek!