-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Refactoring #24
Conversation
@leek There is already a complete refactoring in the bundle in the refactoring branch (not yet completed but @schmittjoh does not have much time for it right now and so is searching someone to help finish it) so we won't do another parallel refactoring |
@stof I've seen the branch you're referring to and it is extremely (3 months) behind
|
@leek the refactoring has been started by @schmittjoh and then stayed pending because of missing time. And it is intended to become the only maintained version of the FOS bundle in the future (the current version is approximately @arnaud-lb's original bundle). So a better way to invest time would be to contact @schmittjoh to help on the refactoring instead of working on another one |
@stof Well this version is basically done and has everything on the ToDo list completed. For anyone who wants a fully functioning OAuth 2.0 bundle (at least until @schmittjoh is done with his branch), I will be maintaining a fork under my namespace here: LeekOAuthServerBundle |
@willdurand Sure. I haven't updated my fork recently but my local version has a few other additions like a base skeleton for requesting a clientId, allowing users to de-authorize a clientId, etc. /cc #26 |
@leek any news? |
s/authentification/authentication/
Update authorize routing file in README
Merged. Thank you so much @leek! |
Done:
/authorize
RefreshToken.mongodb.xml
FOS
bundlesTodo:
Update unit testsThey already pass? Must not be thorough yet...Configuration
/FOSOAuthServerExtension
to prevent BC breaksStill highly work in progress, but I'd love thoughts/suggestions/criticisms/etc.
Fixes #22, #23, #7, #19