minor #1967 Mark deprecated since Symfony 4.2 for Controller (phamuye…

…ntri)

This PR was squashed before being merged into the 2.4-dev branch (closes #1967).

Discussion
----------

Mark deprecated since Symfony 4.2 for Controller

Create new `AbstractFOSRestController` and mark `FOSRestController` as deprecated because `Symfony\Bundle\FrameworkBundle\Controller\Controller` is deprecated in Symfony 4.2

Commits
-------

d84adf0 Mark deprecated since Symfony 4.2 for Controller

Controller/AbstractFOSRestController.php

@@ -0,0 +1,50 @@
+<?php
+
+/*
+ * This file is part of the FOSRestBundle package.
+ *
+ * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace FOS\RestBundle\Controller;
+
+use FOS\RestBundle\View\ViewHandlerInterface;
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+
+/**
+ * Controllers using the View functionality of FOSRestBundle.
+ */
+abstract class AbstractFOSRestController extends AbstractController
+{
+    use ControllerTrait;
+
+    /**
+     * Get the ViewHandler.
+     *
+     * @return ViewHandlerInterface
+     */
+    protected function getViewHandler()
+    {
+        if (!$this->viewhandler instanceof ViewHandlerInterface) {
+            $this->viewhandler = $this->container->get('fos_rest.view_handler');
+        }
+
+        return $this->viewhandler;
+    }
+
+    /**
+     * {@inheritdoc}
+     *
+     * @return array
+     */
+    public static function getSubscribedServices()
+    {
+        $subscribedServices = parent::getSubscribedServices();
+        $subscribedServices['fos_rest.view_handler'] = ViewHandlerInterface::class;
+
+        return $subscribedServices;
+    }
+}

Controller/FOSRestController.php

@@ -17,6 +17,8 @@
 /**
  * Controllers using the View functionality of FOSRestBundle.
  *
+ * @deprecated since FOSRestBundle 2.5, use {@see AbstractFOSRestController} instead
+ *
  * @author Lukas Kahwe Smith <smith@pooteeweet.org>
  */
 abstract class FOSRestController extends Controller