-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ExceptionValueMap to store exception values (codes or message) instead of trait #1373
Conversation
700b9f5
to
b1d505a
Compare
<argument type="collection"/> <!-- exception codes --> | ||
</service> | ||
|
||
<service id="fos_rest.exception.messages_map" class="FOS\RestBundle\Util\ExceptionValueMap"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be private (public="false"
)
Seems really good 👍 |
should be rebased on master |
do you want to put this into 2.0? |
Yeah it certainly don't affect people and it would be easier to respect bc |
…d resolve by exception, instead of trait
b1d505a
to
a53444e
Compare
Rebased. |
Status: Reviewed @lsmith77 what do you think about removing the required statuses ? It's really annoying to have to rebase a PR each time another one is merged :-/ |
the conflicts is I think nothing related to the required checks .. this is more that git cannot cleanly merge the source branch into the target branch |
@lsmith77 right here yeah but the other rebase were needed by github, nothing related to git. |
Use ExceptionValueMap to store map of exception values (codes or messages)
And use it instead of ClassMapHandlerTrait to get code or message associated with exception
In this case resolve logic is incapsulated in ExceptionValueMap and is not exposed into controller or serialize normalizer.