Fixes #219 - route prefix ignored #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -192,7 +192,7 @@ public function read(RestRouteCollection $collection, \ReflectionMethod $method, | |||
| $annoRequirements['_method'] = $requirements['_method']; | |||
| } | |||
|
|
|||
| $pattern = $annotation->getPattern() ?: $pattern; | |||
| $pattern = $annotation->getPattern() ? $this->routePrefix . '/' . ltrim($annotation->getPattern(), '/') : $pattern; | |||
There was a problem hiding this comment.
Rather than join routePrefix to the pattern w/ a slash, how about this? $this->routePrefix . $annotation->getPattern()
That could possibly allow a prefix to be specified, and then joined to a pattern, without a slash (which is actually something I'd personally like in my own code). So rather than forcing a convention of a slash between prefix & pattern, it would boil down to how the prefix & pattern are defined in the developed app.
I'm thinking I like that approach better, and simplifies the code.
lsmith77
added a commit
that referenced
this pull request
Apr 7, 2013
Fixes #219 - route prefix ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't have much time, so can't donate a test as well, but I've verified that this fixes the missing prefix issue. Tested against yml prefix as well as class annotation prefix, with method @get annotation routes.
Fixes #219