fix exception message for unavailable model manager name #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would just use the exception from the SPL instead of the special one from the DI component |
|
Done. |
|
Good catch, thanks @craue. |
stof
added a commit
that referenced
this pull request
Apr 16, 2015
…(craue) This PR was merged into the 2.0.x-dev branch. Discussion ---------- fix exception message for unavailable model manager name So instead of `You have requested a non-existent parameter "None of the managerParameters resulted in a valid name".` the exception message will now be just `None of the managerParameters resulted in a valid name.`. Let me know if `InvalidArgumentException` doesn't fit here. Commits ------- 6851f1a fixed exception message for unavailable model manager name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So instead of
You have requested a non-existent parameter "None of the managerParameters resulted in a valid name".the exception message will now be justNone of the managerParameters resulted in a valid name..Let me know if
InvalidArgumentExceptiondoesn't fit here.