Remove custom repository mappings #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository classes cannot be defined for mapped superclasses.
|
So, you always need to define it explicitly on the sub-class? |
|
Correct. The UserBundle documentation remains correct form when I revised it a few days ago, so I only had to clean up the mappings here. Mapped super-classes don't support a repository definition at all, actually (if you check the ORM/ODM docs). Mapped documents certainly do, but the definition is explicitly omitted from the inheritance. I submitted a patch for this, but after talking it over with jwage and beberlei, we decided it was possibly an invitation for ambiguous behavior, so the pull request was closed. |
|
Applied |
Closed
Closed
WL-arek
pushed a commit
to wlogic/FOSUserBundle
that referenced
this pull request
Aug 13, 2021
Fix MongoDB schema create error
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.