Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 🐛 Roundtrip merge not working #736

Open
discoebbe opened this issue Mar 15, 2024 · 3 comments · Fixed by #776
Open

[BUG] 🐛 Roundtrip merge not working #736

discoebbe opened this issue Mar 15, 2024 · 3 comments · Fixed by #776
Assignees
Labels
bug Something isn't working Prio High TYPO3 12

Comments

@discoebbe
Copy link

Describe the bug
When saving the extension custom methods inside existing models are deleted

To Reproduce

  1. Create a Model. Save it. Add custom methods.

  2. Configure overwriteSettings for Models like:
    overwriteSettings:
    Classes:
    Controller: merge
    Domain:
    Model: merge
    Repository: merge

  3. Open the Extension in Builder again and save it => all custom methods in the model class file are gone.

Expected behavior
keep custom methods and only add setters and getters for new properties

TYPO3 Version
12.4.11

Extension Builder Version:
12.0.0-beta.1

@PKuhlmay PKuhlmay added bug Something isn't working TYPO3 12 labels Mar 15, 2024
@discoebbe
Copy link
Author

Same wrong behavior for Controllers and Repositories

@PKuhlmay
Copy link
Collaborator

Thank you. I will have a look at it. If you know how to solve this, pull requests are welcome 😅

@PKuhlmay PKuhlmay changed the title Roundtrip merge not working on Models [BUG] 🐛 Roundtrip merge not working on Models Mar 24, 2024
@PKuhlmay PKuhlmay changed the title [BUG] 🐛 Roundtrip merge not working on Models [BUG] 🐛 Roundtrip merge not working Mar 27, 2024
@PKuhlmay
Copy link
Collaborator

It seems it broke at commit 733e71cf8a31d84fd3be67bb17410f003348cc94

@PKuhlmay PKuhlmay pinned this issue Apr 2, 2024
@PKuhlmay PKuhlmay self-assigned this Apr 3, 2024
@PKuhlmay PKuhlmay added this to the Next v12 Release milestone Apr 3, 2024
@PKuhlmay PKuhlmay linked a pull request Apr 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Prio High TYPO3 12
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants