[BUGFIX] Avoid php-cs-fixer 3.5.0 #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 3.5.0 has a bug concerning intersection types that breaks our build. Fixes #368
lukaszuznanski
approved these changes
Jan 26, 2022
sbuerk
added a commit
to sbuerk/testing-framework
that referenced
this pull request
Mar 4, 2022
To increase and maintain code quality has been added using
php-cs-fixer and typo3/coding-standards to this package.
CGL run changed two method return types in a way which leads
to a bunch of fails in core phpstan scans.
This is a already known bug of php-cs-fixer, reported for
version 3.5.0 but also 3.6.0 will change this the same way.
This patch reverts the return-type docblock change for
* 'BaseTestClass::getAccessibleMock()'
* 'BaseTestClass::getAccessibleMockForAbstractClass()'
and additional add following to composer.json conflict section:
"friendsofphp/php-cs-fixer": "3.5.0 || 3.6.0"
Further reads:
PHP-CS-Fixer/PHP-CS-Fixer#6238
FriendsOfTYPO3/tea#371
FriendsOfTYPO3/tea@a999668
Releases: main, 7, 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.5.0 has a bug concerning intersection types that breaks our
build.
Fixes #368