Don't ask user to select build type, grab them all #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fris0uman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
When one of the build type is unavailable the launcher doesn't communicate clearly what's going on and user might fail to switch build type to fix the issue
Fixes #68
When all build of one types are unavailable the launcher will let you try to get one anyway which leads to an un unclear error
This Pr aims to fix both error by having
the launcher automatically switch to the other build type if enough builds are unavailableActually we never needed to let user select the build type in the first place, let's just get rid of the option and grab all the available builds. This should solve the issue by always showing the available builds (msvc or other) if they exists.
If all builds fail for both other and msvc for a 100 build happens in the future we can revisit this and add something to tell players it's not the launcher's fault