Only format on forks #205
Merged
Only format on forks #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AWESOME! I'll wander through and test this with my code and we'll get it
merged
Jeff
…On Wed, Sep 13, 2023 at 9:00 AM Tero Kilpeläinen ***@***.***> wrote:
As suggested on stream, I changed the formatting action to only happen on
forked repositories (if: github.ref != 'refs/heads/main' &&
github.repository != 'FritzAndFriends/TagzApp')
This solves the permission issues.
I forget if the workflows are enabled by default on forks or not, if not
the docs might need to mention it.
------------------------------
You can view, comment on, or merge this pull request online at:
#205
Commit Summary
- 6bc3924
<6bc3924>
separeted formatting from dotnet.yml
- f0227a4
<f0227a4>
small changes to trigger formatting on my fork
- c05e1a4
<c05e1a4>
Applying formatting changes through GitHub Actions
File Changes
(4 files <https://github.com/FritzAndFriends/TagzApp/pull/205/files>)
- *M* .github/workflows/dotnet.yml
<https://github.com/FritzAndFriends/TagzApp/pull/205/files#diff-d5a2cea578a0446aad66faf31bf1076ae94c9916b1a3374e342272a6300e8344>
(103)
- *A* .github/workflows/formatting.yml
<https://github.com/FritzAndFriends/TagzApp/pull/205/files#diff-57b2d68e3964418734692feb6e1ac044211b5d270138d3a00199864ca8f15a22>
(95)
- *M* src/TagzApp.Providers.TwitchChat/StartTwitchChat.cs
<https://github.com/FritzAndFriends/TagzApp/pull/205/files#diff-c57fabfe37c28779abe2a2d1845a08bc1802e3e971613463fd1994624a1239fd>
(82)
- *M* src/TagzApp.Web/wwwroot/js/masonry.js
<https://github.com/FritzAndFriends/TagzApp/pull/205/files#diff-0b873a003e0d0f984eca39d0c88fd3642afa05b7e42a94b2b44dddc151ea1d93>
(58)
Patch Links:
- https://github.com/FritzAndFriends/TagzApp/pull/205.patch
- https://github.com/FritzAndFriends/TagzApp/pull/205.diff
—
Reply to this email directly, view it on GitHub
<#205>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAATF4P3WBTQFWSMKNYJPZTX2GVALANCNFSM6AAAAAA4WMTWDY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Looks great! Let's get this merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested on stream, I changed the formatting action to only happen on forked repositories (
if: github.ref != 'refs/heads/main' && github.repository != 'FritzAndFriends/TagzApp')This solves the permission issues.
I forget if the workflows are enabled by default on forks or not, if not the docs might need to mention it.