Fix sorting issue when attribute is method

FrostyX · Jan 27, 2015 · 8647146 · 8647146
1 parent b1c23af
commit 8647146
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/tracer/resources/collections.py b/tracer/resources/collections.py
@@ -18,15 +18,18 @@
 
 from __future__ import absolute_import
 
-from operator import attrgetter
+from operator import attrgetter, methodcaller
 from psutil import NoSuchProcess
 from tracer.resources.system import System
 
 
 class Collection(list):
 
 	def sorted(self, attribute):
-		return sorted(self, key=attrgetter(attribute))
+		try:
+			return sorted(self, key=methodcaller(attribute))
+		except TypeError:
+			return sorted(self, key=attrgetter(attribute))
 
 
 class ApplicationsCollection(Collection):

diff --git a/tracer/views/resource/processes.py b/tracer/views/resource/processes.py
@@ -6,6 +6,5 @@ def render(self):
 		line = "{0:<10}{1:<20}{2:<20}{3:<10}"
 		print line.format("PID", "Time running", "User", "Process")
 		print 100 * "-"
-		# @FIXME sorting doesn't work correctly
 		for process in self.args.processes.sorted("create_time"):
 			print line.format(process.pid, process.str_started_ago, process.username(), process.name())