Create /var/run/reboot-required file

[FrostyX]

Fix #195

[FrostyX]

RPM available here: https://copr.fedorainfracloud.org/coprs/frostyx/tracer/build/5929476/

[xsuchy]

Can this be written more cleanly:

		if self.applications.count_type(Applications.TYPES["STATIC"]):
			with open("/var/run/reboot-required", "w") as fp:
                        ...

[FrostyX]

Sure, updated

[major]

So I tried the code from this PR and I didn't see the file being written. Perhaps I didn't do something correctly.

Output:

You should restart:
  * Some applications using:
      sudo systemctl restart NetworkManager
      sudo systemctl restart auditd
      sudo systemctl restart chronyd
      sudo systemctl restart dbus-broker
      sudo systemctl restart qemu-guest-agent
      sudo systemctl restart sshd
      sudo systemctl restart systemd-journald
      sudo systemctl restart systemd-logind
      sudo systemctl restart systemd-oomd
      sudo systemctl restart systemd-resolved
      sudo systemctl restart systemd-udevd
      sudo systemctl restart systemd-userdbd

  * These applications manually:
      (sd-pam)
      dnf

Additionally, there are:
  - 3 processes requiring restart of your session (i.e. Logging out & Logging in again)
  - 1 processes requiring reboot

For more information run:
    sudo tracer -iat 1684410627.5498843

But no file was written:

[root@tracer-testing ~]# cat /var/run/reboot-required
cat: /var/run/reboot-required: No such file or directory

[major]

Nevermind -- an update in F38 clobbered the testing RPM from this change. This works just fine! 🥳

[root@tracer-testing ~]# tracer 
You should restart:
  * Some applications using:
      sudo systemctl restart NetworkManager
      sudo systemctl restart auditd
      sudo systemctl restart chronyd
      sudo systemctl restart dbus-broker
      sudo systemctl restart qemu-guest-agent
      sudo systemctl restart sshd
      sudo systemctl restart systemd-journald
      sudo systemctl restart systemd-logind
      sudo systemctl restart systemd-oomd
      sudo systemctl restart systemd-resolved
      sudo systemctl restart systemd-udevd
      sudo systemctl restart systemd-userdbd

  * These applications manually:
      (sd-pam)

Additionally, there are:
  - 3 processes requiring restart of your session (i.e. Logging out & Logging in again)
  - 1 processes requiring reboot
[root@tracer-testing ~]# cat /var/run/reboot-required 
Tracer says reboot is required

[FrostyX]

Perfect, thank you for the test.

[keszybz]

The correct location is /run, not /var/run. In most cases, this doesn't matter greatly, because a compat symlink is provided, but when /var is a separate partition, /var/run would only be accessible if /var is mounted, i.e. rather late in boot. /run is always available. /var/run is a compat symlink that should not be used (esp. in new code).

[FrostyX]

Thank you @keszybz,
if I change the location, will this be okay with you @major?

[major]

@FrostyX should be fine!