Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vtable for windows 11 22489 and up #10

Merged
merged 2 commits into from
Apr 3, 2022

Conversation

cpbotha
Copy link
Contributor

@cpbotha cpbotha commented Apr 3, 2022

VD.ahk stopped working over here on the Windows 11 Insider Preview Build 22581 that was released to Beta and Dev.

Based on the changes in https://github.com/MScholtes/VirtualDesktop/blob/master/VirtualDesktop11Insider.cs this PR updates VD.ahk to selectively fix the vtable when windows version >= 22489.

@FuPeiJiang FuPeiJiang closed this in d2c1b2c Apr 3, 2022
@FuPeiJiang FuPeiJiang merged commit d2c1b2c into FuPeiJiang:class_VD Apr 3, 2022
@FuPeiJiang
Copy link
Owner

thank you for that

I'm glad you were able to find out about MScholtes's repo (source of vtable offset)
was it in the comments ? or notes\ ? or issues ? or README.md ?


I checked out your repo :) :D
I see that you are using git submodules
https://github.com/cpbotha/vxdesktops.ahk
while I'm manually copy pasting it to update it
because of this ONE thing
https://github.com/FuPeiJiang/ahk_explorer/blob/b2e7fced769547e80de965863e6b9035d3ea8317/lib/VD.ahk#L44

    ; COMMENT THIS OUT IF YOU DON'T WANT TO INIT AT START OF SCRIPT
    ; static dummyStatic1 := VD.init()

do you know of a way ?

@cpbotha
Copy link
Contributor Author

cpbotha commented Apr 4, 2022

Thank you for handling this so quickly @FuPeiJiang !

Fortunately you had left comments in the VD.ahk code pointing to VirtualDesktop (I think the GUIDs specifically) -- so I could go back there and see what had changed.

w.r.t. the init -- I am not an AHK language expert, but you could consider making an init-less VD class (e.g. VD-user-init.ahk), and then wrapping that in an init-doing VD class (VD.ahk). Existing users would get the same, simple experience, while expert users could include VD-user-init.ahk instead, and do the .init() themselves.

FuPeiJiang added a commit that referenced this pull request Apr 4, 2022
thanks to cpbotha
#10 (comment)

; include "VD.ahk" to automatically init at start of script
; include "_VD.ahk" to manually `VD.init()` when you want, like after a GUI has rendered
FuPeiJiang added a commit that referenced this pull request Apr 4, 2022
thanks to cpbotha
#10 (comment)

; include "VD.ahk" to automatically init at start of script
; include "_VD.ahk" to manually `VD.init()` when you want, like after a GUI has rendered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants