Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ' in rust-mode intelligently. #526

Merged
merged 1 commit into from Nov 12, 2015

Conversation

Wilfred
Copy link
Collaborator

@Wilfred Wilfred commented Nov 3, 2015

Fixes #512.

Wilfred added a commit to Wilfred/.emacs.d that referenced this pull request Nov 6, 2015
@Fuco1
Copy link
Owner

Fuco1 commented Nov 7, 2015

You can use sp-test-with-temp-buffer instead of your own setup function. It should be understandable from the docstring or you can search the tests for an example.

I will write something about the "test framework" hopefully soon enough :P

@Wilfred
Copy link
Collaborator Author

Wilfred commented Nov 9, 2015

Aha, I didn't know about sp-test-with-temp-buffer. I've pushed a new commit, let me know if you'd prefer I squashed it.

@Fuco1
Copy link
Owner

Fuco1 commented Nov 9, 2015

Yes please, squash and then we merge! Thanks.

@Wilfred
Copy link
Collaborator Author

Wilfred commented Nov 12, 2015

Squashed :)

Fuco1 added a commit that referenced this pull request Nov 12, 2015
@Fuco1 Fuco1 merged commit fa0d8b8 into Fuco1:master Nov 12, 2015
@Fuco1
Copy link
Owner

Fuco1 commented Nov 12, 2015

Bam, thanks!

@Wilfred Wilfred deleted the handle_apostrophe_rust_mode branch November 12, 2015 22:48
@cipherself
Copy link

Nice! Thanks @Wilfred and @Fuco1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants