Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Add MCPI Opcode #21

Closed
vlopes11 opened this issue Sep 28, 2021 · 1 comment · Fixed by #24
Closed

Add MCPI Opcode #21

vlopes11 opened this issue Sep 28, 2021 · 1 comment · Fixed by #24
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vlopes11
Copy link
Contributor

vlopes11 commented Sep 28, 2021

Implement https://github.com/FuelLabs/fuel-specs/blob/master/specs/vm/opcodes.md#mcpi-memory-copy-immediate

Steps

  1. Include an opcode identifier (from and to u8) in https://github.com/FuelLabs/fuel-asm/blob/master/src/opcode/consts.rs
  2. Add the opcode variant with the documentation in https://github.com/FuelLabs/fuel-asm/blob/master/src/opcode.rs
    1. The constant representation defined in the previous step must be implemented in https://github.com/FuelLabs/fuel-asm/blob/master/src/opcode.rs#L1265
    2. The references to ra and rb must be defined in https://github.com/FuelLabs/fuel-asm/blob/master/src/opcode.rs#L1369
    3. The opcode into half word implementation must be added in https://github.com/FuelLabs/fuel-asm/blob/master/src/opcode.rs#L1492
  3. Add the new opcode to the test cases for encode/decode: https://github.com/FuelLabs/fuel-asm/blob/master/tests/encoding.rs#L11
@adlerjohn adlerjohn linked a pull request Oct 14, 2021 that will close this issue
@sezna
Copy link

sezna commented Nov 3, 2021

Whenever this is done, I have a branch ready for it at sezna/mcpi-opcode in sway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants