feat: update compatibility with fuel-core v0.20 #34
Conversation
luizstacio
changed the title
| @@ -15,7 +15,7 @@ impl MessageData { | |||
| /// | |||
| /// any data beyond 160 bytes means deposit is meant for a contract. | |||
| /// if data is > 161 bytes, then we also need to call process_message on the destination contract. | |||
| pub fn parse(msg_idx: u8) -> Self { | |||
| pub fn parse(msg_idx: u64) -> Self { | |||
There was a problem hiding this comment.
This was changed because sway methods input_message_data_length and input_message_data now receive a u64.
There was a problem hiding this comment.
ah this is likely because sway doesn't allow for implicit integer casting now? Since I don't think the stdlib changed here. The strange thing to me is that it seems like we should be able to safely upcast ints without any concerns for precision.
cc @IGI-111
There was a problem hiding this comment.
Yeah we have safe upcasts, though they have to be explicitly called.
I'm not sure if this should be fixed here or on the library side however.
Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
| @@ -74,8 +75,10 @@ impl MessageReceiver for Contract { | |||
| register_refund(message_data.from, message_data.token, message_data.amount); | |||
| }, | |||
| Result::Ok(amount) => { | |||
| let subId: SubId = ZERO_B256; | |||
| let tokenId = sha256((contract_id(), subId)); | |||
There was a problem hiding this comment.
[nit] there is a helper function for this in the stdlib now std::asset_id::construct_default_asset_id.
https://github.com/FuelLabs/sway/blob/master/sway-lib-std/src/asset_id.sw#L15
| fuel-core-types = { version = "0.19.1", default-features = false } | ||
| fuels = { version = "0.44", features = ["fuel-core-lib"] } | ||
| fuel-core-types = { version = "0.20.4", default-features = false } | ||
| fuels = { version = "0.45.1", features = ["fuel-core-lib"] } |
| @@ -63,14 +64,16 @@ mod success { | |||
| ) | |||
| .await; | |||
|
|
|||
| println!("receipts: {:#?}", receipts); | |||
There was a problem hiding this comment.
We ought to keep debugging statements out of tests
packages/fungible-token/bridge-fungible-token/tests/functions/bridge/mod.rs
Show resolved
Hide resolved
close: #17