Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BlockHeader hash #1868

Merged
merged 11 commits into from
Apr 29, 2024
Merged

Fix BlockHeader hash #1868

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
80ae610
Add event_inbox_root to `hash`
MitchTurner Apr 26, 2024
f71c368
Update CHANGELOG
MitchTurner Apr 26, 2024
de45a49
Remove the padding thing from CHANGELOG
MitchTurner Apr 26, 2024
7a51d92
Use unpadded values for calculating hash
MitchTurner Apr 26, 2024
da5e3c8
Merge branch 'master' into fix/correct-header-id-calculation
xgreenx Apr 29, 2024
888df2a
Use `u16` and `u32` instead of the `u64`
xgreenx Apr 29, 2024
1ee7a66
Merge branch 'master' into fix/correct-header-id-calculation
xgreenx Apr 29, 2024
3894794
Merge branch 'master' into fix/correct-header-id-calculation
xgreenx Apr 29, 2024
581ef25
Merge branch 'master' into fix/correct-header-id-calculation
xgreenx Apr 29, 2024
401e04e
Updated CHANGELOG.md
xgreenx Apr 29, 2024
8dfd371
Merge branch 'master' into fix/correct-header-id-calculation
xgreenx Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/types/src/blockchain/header.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,7 @@ impl ApplicationHeader<GeneratedApplicationFields> {
hasher.input(self.message_receipt_count.to_be_bytes());
hasher.input(self.transactions_root.as_ref());
hasher.input(self.message_outbox_root.as_ref());
hasher.input(self.event_inbox_root.as_ref());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any logic to the order these things get added to the hash?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of fields in the header

hasher.input(self.consensus_parameters_version.to_bytes().as_slice());
hasher.input(self.state_transition_bytecode_version.to_bytes().as_slice());
hasher.digest()
Expand Down
Loading