Updated VM initialization benchmark to include many inputs and outputs #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
MitchTurner
reviewed
Jun 15, 2024
| @@ -75,12 +96,13 @@ fn transaction<R: Rng>( | |||
|
|
|||
| pub fn vm_initialization(c: &mut Criterion) { | |||
| let mut rng = StdRng::seed_from_u64(8586); | |||
| let consensus_params = ConsensusParameters::default(); | |||
| let mut consensus_params = ConsensusParameters::default(); | |||
| consensus_params.set_tx_params(TxParameters::default().with_max_size(256 * 1024)); | |||
There was a problem hiding this comment.
Where does 256 * 1024 come from?
There was a problem hiding this comment.
From the current configuration of the network. Testnet currently allows 256KB
MitchTurner
approved these changes
Jun 15, 2024
xgreenx
deleted the
feature/vm-initialization-benchmark-include-inputs-and-outptus
branch
Merged
xgreenx
added a commit
that referenced
this pull request
Jun 16, 2024
## Version v0.30.0 ### Added - [#1975](#1975): Added `DependentCost` benchmarks for the `cfe` and `cfei` opcodes. - [#1975](#1975): Added `DependentCost` for the `cfe` opcode to the `GasCosts` endpoint. - [#1974](#1974): Optimized the work of `InMemoryTransaction` for lookups and empty insertion. ### Changed - [#1973](#1973): Updated VM initialization benchmark to include many inputs and outputs. #### Breaking - [#1975](#1975): Updated gas prices according to new release. - [#1975](#1975): Changed `GasCosts` endpoint to return `DependentCost` for the `cfei` opcode via `cfeiDependentCost`. - [#1975](#1975): Use `fuel-vm 0.54.0`. More information in the [release](https://github.com/FuelLabs/fuel-vm/releases/tag/v0.54.0). ## What's Changed * Add `creation_instant` as second sort key in tx pool. by @AurelienFT in #1964 * Updated VM initialization benchmark to include many inputs and outputs by @xgreenx in #1973 * Fixes the error message for incorrect keypair's path by @xgreenx in #1962 * Optimized the work of `InMemoryTransaction` for lookups and empty insertion by @xgreenx in #1974 * Weekly `cargo update` by @github-actions in #1976 * Use `fuel-vm 0.54.0` by @xgreenx in #1975 **Full Changelog**: v0.29.0...v0.30.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers new behavior from FuelLabs/fuel-vm#770
Before requesting review