Cache contract inputs in the VM #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
MitchTurner
reviewed
Jun 15, 2024
| panic_context, | ||
| } | ||
| } | ||
|
|
||
| /// Checks that the contract is declared in the transaction inputs. | ||
| pub fn check(&mut self, contract: &ContractId) -> SimpleResult<()> { | ||
| if !self.tx_input_contracts.any(|input| input == contract) { | ||
| if !self.input_contracts.contains(contract) { |
There was a problem hiding this comment.
Essentially, the idea of this PR is making this lookup more performant? Is that right?
| @@ -41,6 +45,33 @@ where | |||
| ) -> Result<(), RuntimeError<S::DataError>> { | |||
| tx.prepare_init_execute(); | |||
| self.tx = tx; | |||
| self.input_contracts = self | |||
There was a problem hiding this comment.
So we might be taking a bit of a hit on performance because of this, but at least its constant time and not an attack vector?
There was a problem hiding this comment.
Yes, we calculate it each time now during initialization and later all related operations will be fast
MitchTurner
previously approved these changes
Jun 15, 2024
MitchTurner
approved these changes
Jun 15, 2024
Merged
xgreenx
added a commit
to FuelLabs/fuel-core
that referenced
this pull request
Jun 15, 2024
#1973) Covers new behavior from FuelLabs/fuel-vm#770 ### Before requesting review - [x] I have reviewed the code myself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #761
Updated benchmark to cover worst case FuelLabs/fuel-core#1973
Checklist
Before requesting review