Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to latest version #28

Merged
merged 23 commits into from
May 29, 2024
Merged

chore: bump to latest version #28

merged 23 commits into from
May 29, 2024

Conversation

sarahschwartz
Copy link
Contributor

@sarahschwartz sarahschwartz commented Apr 16, 2024

This PR bumps the docs to reflect the latest version of fuel-core

@sarahschwartz sarahschwartz self-assigned this Apr 16, 2024
bvrooman
bvrooman previously approved these changes May 18, 2024
Copy link
Contributor

@bvrooman bvrooman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over the reference changes and made a few suggestions for spelling (ie. Merkle over merkle, since it's a name). The definitions look correct and straight forward to me. You may want to get additional eyes from others on the Client team if possible. I did not check the correctness of the examples by actually running them - are these changes confirmed? Overall, lgtm.

docs/reference/objects.mdx Outdated Show resolved Hide resolved
docs/reference/objects.mdx Outdated Show resolved Hide resolved
docs/reference/objects.mdx Outdated Show resolved Hide resolved
docs/reference/objects.mdx Outdated Show resolved Hide resolved
docs/reference/objects.mdx Outdated Show resolved Hide resolved
Co-authored-by: Brandon Vrooman <brandon.vrooman@gmail.com>
Copy link
Member

@Dentosal Dentosal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @bvrooman here, the doc changes look good, but I didn't try out all of the examples either. Assuming those work, LGTM.

@sarahschwartz sarahschwartz enabled auto-merge (squash) May 29, 2024 15:00
@sarahschwartz sarahschwartz merged commit ab1a0a6 into main May 29, 2024
9 checks passed
@sarahschwartz sarahschwartz deleted the sarah/bump branch May 29, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants