Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the GasPrice Policy to Tips and implement it accordingly. #664

Closed
MitchTurner opened this issue Jan 25, 2024 · 3 comments · Fixed by #682
Closed

Rename the GasPrice Policy to Tips and implement it accordingly. #664

MitchTurner opened this issue Jan 25, 2024 · 3 comments · Fixed by #682
Assignees

Comments

@MitchTurner
Copy link
Member

MitchTurner commented Jan 25, 2024

Before the tx submitter would specify the gas price they wanted via the tx policies but that will now be specified for each block instead. The GasPrice policy will instead be used to specify how much extra the tx submitter wants to spend to incentivise block producers to choose their tx. This is similar to the "priority fee" in EIP 1559. We are choosing to call this a "tip", which is an intuitive description of what it's for.

Part of this is coverage in the metadata tests.

@MitchTurner
Copy link
Member Author

MitchTurner commented Feb 1, 2024

Not necessarily gas price, but maybe fee. Gas price is the rate for gas, tip implies an extra sum.

@MitchTurner
Copy link
Member Author

Do we need another story for including tips in the fee calculation? Because this story replaces the use of GasPrice in fee calc:
#672

@xgreenx
Copy link
Collaborator

xgreenx commented Feb 12, 2024

We need, but I think it will be implemented during #665 (comment)

@MitchTurner MitchTurner changed the title Rename gas price to tips Add Tips to Policies where GasPrice used to be. Feb 13, 2024
@MitchTurner MitchTurner changed the title Add Tips to Policies where GasPrice used to be. Rename the GasPrice Policy to Tips and implement it accordingly. Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants