-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include tip in fee #682
Include tip in fee #682
Conversation
This reverts commit e8ae067.
c17c550
to
9c61f28
Compare
I feel like I'm probably forgetting something. |
fuel-tx/src/transaction/fee.rs
Outdated
@@ -166,12 +179,14 @@ pub trait Chargeable: field::Inputs + field::Witnesses + field::Policies { | |||
gas_costs: &GasCosts, | |||
fee: &FeeParameters, | |||
gas_price: Word, | |||
tip: Word, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you want to get it from the policies
fuel-tx/src/transaction/fee.rs
Outdated
@@ -150,12 +161,14 @@ pub trait Chargeable: field::Inputs + field::Witnesses + field::Policies { | |||
gas_costs: &GasCosts, | |||
fee: &FeeParameters, | |||
gas_price: Word, | |||
tip: Word, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you want to get it from the policies
Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update the refund_when_used_gas_is_zero
test please?=)
Closes: #664