Unit tests for op functions #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-vm into freesig/avoid-code-clone-2
…-vm into freesig/unit-test-call
|
Now have at least one unit test per op function. |
freesig
force-pushed
the
freesig/unit-test-all-op-fns
branch
from
b175852
to
4ffd77b
Compare
freesig
force-pushed
the
freesig/unit-tests-for-op-fns
branch
from
a8bda42
to
5558f53
Compare
…into freesig/unit-test-all-op-fns
…t-test-all-op-fns
freesig
force-pushed
the
freesig/unit-tests-for-op-fns
branch
from
5558f53
to
2362071
Compare
Voxelot
reviewed
Mar 1, 2023
| pc: RegMut::new(&mut pc), | ||
| }; | ||
| let mut dest = 0; | ||
| alu_capture_overflow(&mut dest, Reg::new(&flag), common, u128::overflowing_add, b, c) |
There was a problem hiding this comment.
I feel like we should consider wrapping add more fully into it's own fn, as this is basically a copy/paste of what add does rather than testing the same exact add logic used by the interpreter.
There was a problem hiding this comment.
Yeh but this is true for basically all the ops in alu. I guess the point is to more unit test the actual function alu_capture_overflow
Voxelot
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds at least one unit test per op functions but some have full coverage.