chore: Simplify InterpreterStorage
#683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvrooman
changed the title
InterpreterStorage
Dentosal
reviewed
Feb 22, 2024
| @@ -248,23 +242,6 @@ impl StorageMutate<ContractsAssets> for MemoryStorage { | |||
| } | |||
| } | |||
|
|
|||
| impl MerkleRootStorage<ContractId, ContractsAssets> for MemoryStorage { | |||
There was a problem hiding this comment.
I'm a bit surprised that this can just be removed.
Dentosal
approved these changes
Feb 22, 2024
xgreenx
approved these changes
Feb 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
Vec<u8>as a value for theContractsStatetable #655Currently, the
InterpreterStoragetrait has two issues:MerkleRootStoragewhich can be removed.merkle_; however, implementations of these methods do not necessarily need to Merklize the data, and it is the responsibility of specific implementations to understand when Merklization is needed.By removing the
merkle_prefix, we make it more clear that the methods are simply methods to query or mutate data in interpreter storage. Any Merklization is an internal detail. Additionally, this means that implementations of these methods that do not apply Merklization, i.e. forMemoryStorage, are more congruent with the method name.This enables future interface changes to be done more easily and with greater confidence in their correctness.