Test ALU opcodes using only the external interface #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchTurner
reviewed
Jun 19, 2024
| normal: run(Flags::empty()), | ||
| wrapping: run(Flags::WRAPPING), | ||
| unsafemath: run(Flags::UNSAFEMATH), | ||
| wrapping_unsafemath: run(Flags::WRAPPING | Flags::UNSAFEMATH), |
There was a problem hiding this comment.
Why isn't this & instead of |? Am I missing something? (same thing below)
There was a problem hiding this comment.
Thse are bitflags. | combines them. imagine unsafemath = 1 (0b01), wrapping = 2 (0b10). Now 0b01 & 0b10 == 0b00 and 0b01 | 0b10 == 0b11
MitchTurner
approved these changes
Jun 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #746
Refactors ALU testing to only use instruction execution. Removes lots of code, tests lots of previously untested cases, and keeps the old code coverage numbers (master, this PR).
Before requesting review