Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: derive Default for SizedAsciiString #1086

Merged
merged 1 commit into from
Aug 15, 2023
Merged

chore: derive Default for SizedAsciiString #1086

merged 1 commit into from
Aug 15, 2023

Conversation

ra0x3
Copy link

@ra0x3 ra0x3 commented Aug 15, 2023 •
edited
Loading

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Description

  • Really hoping this is the last SizedAsciiString update 🤞🏽

@ra0x3 ra0x3 self-assigned this Aug 15, 2023
@ra0x3 ra0x3 marked this pull request as draft August 15, 2023 16:09
@ra0x3 ra0x3 force-pushed the rashad/impl-default-for-sized-ascii branch from d2edc75 to c6ad838 Compare August 15, 2023 16:13
@ra0x3 ra0x3 marked this pull request as ready for review August 15, 2023 16:22
@ra0x3 ra0x3 enabled auto-merge (squash) August 15, 2023 17:41
@ra0x3 ra0x3 merged commit fd7e507 into master Aug 15, 2023
36 checks passed
@ra0x3 ra0x3 deleted the rashad/impl-default-for-sized-ascii branch August 15, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@Salka1988 Salka1988 Salka1988 approved these changes

@iqdecay iqdecay iqdecay approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@hal3e hal3e Awaiting requested review from hal3e hal3e is a code owner

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

Assignees

@ra0x3 ra0x3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ra0x3 @Br1ght0ne @Salka1988 @iqdecay