feat!: remove legacy decoding #1357
Merged
+74
−3,851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hal3e
requested review from
digorithm,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
Salka1988
reviewed
May 2, 2024
segfault-magnet
approved these changes
May 2, 2024
Salka1988
approved these changes
May 2, 2024
digorithm
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
legacy_encodingfeature and uses the new encoding for everything except configurables. The legacy decoding code has been removed. The legacy encoding code is still used by configurables and will be removed in #1338.BREAKING CHANGE:
resolve_fn_selectortoencode_fn_selector