-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove legacy encoding #1338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So configurables are broken until the sway issue is fixed? Do we plan on releasing this before the fix for whatever cyclic-dep reason?
packages/fuels-code-gen/src/program_bindings/abigen/bindings/function_generator.rs
Outdated
Show resolved
Hide resolved
IMO we should wait until we have support for configurables with the new encoding. |
Can we not wait for it, instead? The support for the new encoding in configurables might take a few days or a week, and it might delay the testnet release. Can we push this without supporting configurables (i.e., configurables would still use only the legacy encoding) for now, and add it later? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this merged, it's blocking the core update.
yes we can do that but not in this PR as here the legacy encoding is completely gone. Here is the new PR: #1357 |
packages/fuels-code-gen/src/program_bindings/abigen/bindings/function_generator.rs
Outdated
Show resolved
Hide resolved
…unction_generator.rs Co-authored-by: MujkicA <32431923+MujkicA@users.noreply.github.com>
b2d5638
closes: #1318
This PR removes all code related to the legacy encoding.
Blocked by configurables not supporting new encoding. Issue to track: FuelLabs/sway#5727
BREAKING CHANGE:
resolve_fn_selector
toencode_fn_selector
Checklist