Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add messages support #555

Merged
merged 30 commits into from
Sep 13, 2022
Merged

feat!: Add messages support #555

merged 30 commits into from
Sep 13, 2022

Conversation

Salka1988
Copy link
Member

No description provided.

@Salka1988 Salka1988 marked this pull request as draft August 31, 2022 22:15
@Salka1988 Salka1988 changed the title add get_messages add messages support Sep 2, 2022
@Salka1988 Salka1988 linked an issue Sep 2, 2022 that may be closed by this pull request
InputMessage support #530
Closed
@Salka1988 Salka1988 removed a link to an issue Sep 2, 2022
InputMessage support #530
Closed
@Salka1988 Salka1988 linked an issue Sep 2, 2022 that may be closed by this pull request
InputMessage support #530
Closed
@Salka1988
Merge branch 'master' into Salka1988/input_message_support
d027b0d
@Salka1988
add spend input_message
feb3bbf
@Salka1988
add message_config for duel-core.bin
f758700
@Salka1988
Merge branch 'master' into Salka1988/input_message_support
21fdc93 
# Conflicts:
#	packages/fuels/tests/harness.rs
@Salka1988
Merge branch 'master' into Salka1988/input_message_support
de55cb1 
# Conflicts:
#	packages/fuels-contract/src/contract.rs
#	packages/fuels-contract/src/script.rs
#	packages/fuels-signers/src/provider.rs
#	packages/fuels-signers/src/wallet.rs
@Salka1988
add merge master
ae4e816
@Salka1988
add spend input_message for tx fees
236e076
@Salka1988 Salka1988 requested review from a team, pixelcircuits and Voxelot September 8, 2022 13:10
@Salka1988 Salka1988 self-assigned this Sep 8, 2022
@Salka1988 Salka1988 marked this pull request as ready for review September 8, 2022 15:50
digorithm
digorithm requested changes Sep 9, 2022
View reviewed changes
packages/fuels-signers/src/wallet.rs Outdated Show resolved Hide resolved
packages/fuels-signers/src/wallet.rs Show resolved Hide resolved
packages/fuels-test-helpers/src/lib.rs Outdated Show resolved Hide resolved
packages/fuels/tests/harness.rs Show resolved Hide resolved
segfault-magnet
segfault-magnet reviewed Sep 9, 2022
View reviewed changes
packages/fuels-signers/src/wallet.rs Outdated Show resolved Hide resolved
packages/fuels-signers/src/wallet.rs Outdated Show resolved Hide resolved
packages/fuels-signers/src/wallet.rs Outdated Show resolved Hide resolved
packages/fuels-test-helpers/src/lib.rs Outdated Show resolved Hide resolved
packages/fuels-test-helpers/src/node.rs Outdated Show resolved Hide resolved
packages/fuels-test-helpers/src/lib.rs Outdated Show resolved Hide resolved
pixelcircuits
pixelcircuits previously approved these changes Sep 11, 2022
View reviewed changes
Copy link

@pixelcircuits pixelcircuits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Br1ght0ne
Br1ght0ne reviewed Sep 12, 2022
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the greatness of my review, still, lots of good things about this PR. 🚀

packages/fuels-signers/src/wallet.rs Outdated Show resolved Hide resolved
packages/fuels/tests/harness.rs Outdated Show resolved Hide resolved
packages/fuels/tests/harness.rs Show resolved Hide resolved
hal3e
hal3e previously approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Br1ght0ne
Br1ght0ne previously approved these changes Sep 12, 2022
View reviewed changes
@Salka1988 Salka1988 dismissed stale reviews from Br1ght0ne and hal3e via af95fd8 September 12, 2022 12:23
digorithm
digorithm approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@digorithm digorithm changed the title add messages support feat!: Add messages support Sep 13, 2022
@digorithm digorithm added enhancement New feature or request breaking Introduces or requires breaking changes labels Sep 13, 2022
@Salka1988 Salka1988 merged commit 2365555 into master Sep 13, 2022
@Salka1988 Salka1988 deleted the Salka1988/input_message_support branch September 13, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Voxelot Voxelot Voxelot left review comments

@MujkicA MujkicA MujkicA left review comments

@digorithm digorithm digorithm approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne left review comments

@pixelcircuits pixelcircuits pixelcircuits left review comments

@hal3e hal3e hal3e left review comments

@iqdecay iqdecay Awaiting requested review from iqdecay

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

Assignees

@Salka1988 Salka1988

Labels
breaking Introduces or requires breaking changes enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InputMessage support
8 participants
@Salka1988 @Voxelot @digorithm @Br1ght0ne @pixelcircuits @MujkicA @hal3e @segfault-magnet