Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add interface for creating scripts #583

Merged
merged 11 commits into from
Sep 26, 2022
Merged

add interface for creating scripts #583

merged 11 commits into from
Sep 26, 2022

Conversation

Salka1988
Copy link
Member

@Salka1988 Salka1988 commented Sep 20, 2022 •
edited
Loading

I added an interface for running scripts in the SDK with the possibility of setting up all fields.

@Salka1988 Salka1988 self-assigned this Sep 20, 2022
@Salka1988 Salka1988 marked this pull request as draft September 20, 2022 13:52
@Salka1988 Salka1988 linked an issue Sep 20, 2022 that may be closed by this pull request
Interface for creating scripts #516
Closed
@Salka1988 Salka1988 changed the title add script interface add interface for creating scripts Sep 20, 2022
hal3e
hal3e reviewed Sep 22, 2022
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a tiny nit.

packages/fuels/tests/harness.rs Outdated Show resolved Hide resolved
@Salka1988 Salka1988 marked this pull request as ready for review September 25, 2022 12:17
Br1ght0ne
Br1ght0ne previously approved these changes Sep 25, 2022
View reviewed changes
@iqdecay iqdecay requested a review from hal3e September 25, 2022 16:16
iqdecay
iqdecay suggested changes Sep 25, 2022
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! This is a great first step for me to work on accepting arguments in main script functions. It would be better with some clarifiacations though 🙂

packages/fuels-contract/src/script.rs Outdated Show resolved Hide resolved
packages/fuels-contract/src/script.rs Show resolved Hide resolved
packages/fuels-signers/src/wallet.rs Show resolved Hide resolved
packages/fuels-test-helpers/src/script.rs Show resolved Hide resolved
packages/fuels-test-helpers/src/script.rs Outdated Show resolved Hide resolved
packages/fuels/tests/harness.rs Show resolved Hide resolved
packages/fuels/tests/harness.rs Show resolved Hide resolved
iqdecay
iqdecay approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/fuels-signers/src/wallet.rs Show resolved Hide resolved
hal3e
hal3e approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Thisi is much better than the first version I reviewed! 🎉

@Salka1988 Salka1988 merged commit cdcf120 into master Sep 26, 2022
@Salka1988 Salka1988 deleted the Salka1988/interface_for_crating_scripts branch September 26, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iqdecay iqdecay iqdecay approved these changes

@hal3e hal3e hal3e approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne left review comments

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

Assignees

@Salka1988 Salka1988

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interface for creating scripts
4 participants
@Salka1988 @Br1ght0ne @iqdecay @hal3e