Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Identity as native type #601

Merged
merged 1 commit into from
Sep 30, 2022
Merged

feat: add Identity as native type #601

merged 1 commit into from
Sep 30, 2022

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Sep 30, 2022

Using Identity in two deployed contracts would result in naming collision as both contract would make their own Identity enum.

This PR fixes that by treating Identity as a native type.

  • Updated abigen to use native Identity
  • Added test for different Identity use-cases

@hal3e hal3e added the bug Something isn't working label Sep 30, 2022
@hal3e hal3e requested a review from a team September 30, 2022 16:41
@hal3e hal3e self-assigned this Sep 30, 2022
digorithm
digorithm approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean, great job!

@hal3e hal3e merged commit 8ce1080 into master Sep 30, 2022
@hal3e hal3e deleted the hal3e/identity-enum-in-sdk branch September 30, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm approved these changes

@iqdecay iqdecay Awaiting requested review from iqdecay

Assignees

@hal3e hal3e

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hal3e @digorithm