Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ignore lock files and out/ directory #623

Merged
merged 2 commits into from
Oct 13, 2022
Merged

fix: Ignore lock files and out/ directory #623

merged 2 commits into from
Oct 13, 2022

Conversation

digorithm
Copy link
Member

No description provided.

@digorithm digorithm self-assigned this Oct 13, 2022
@digorithm digorithm marked this pull request as ready for review October 13, 2022 16:52
@digorithm digorithm requested a review from a team October 13, 2022 16:52
@digorithm digorithm mentioned this pull request Oct 13, 2022
Closed
iqdecay
iqdecay suggested changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're still adding the targets? But I'm not sure

@digorithm
Copy link
Member Author

I think you're still adding the targets? But I'm not sure

Nope, this is the current git status output:
image

@digorithm
Copy link
Member Author

I think you're still adding the targets? But I'm not sure

Nope, this is the current git status output: image

But I'm going to add to the ignore file just in case my fs is doing some funny business haha.

@digorithm digorithm merged commit de9352b into master Oct 13, 2022
@digorithm digorithm deleted the rodrigo/ignore-lock-and-out branch October 13, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iqdecay iqdecay iqdecay approved these changes

@hal3e hal3e hal3e approved these changes

Assignees

@digorithm digorithm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@digorithm @iqdecay @hal3e