Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exiting tests #639

Merged
merged 4 commits into from
Oct 18, 2022
Merged

fix: exiting tests #639

merged 4 commits into from
Oct 18, 2022

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Oct 17, 2022

should close: #631

This is a possible solution for the ctrl-c exit problem with the integration tests. The tests are now separated into files and are not included as modules. Please try it and if we like it I will update the docs.

@hal3e hal3e self-assigned this Oct 17, 2022
@hal3e hal3e requested a review from a team October 17, 2022 13:55
@hal3e hal3e added the bug Something isn't working label Oct 17, 2022
iqdecay
iqdecay previously approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, and tested it locally an can now Ctrl-C the tests as I please! Great :)

EDIT: approval on condition that the TODO added about the structure is done hehe

digorithm
digorithm previously approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I pretty much prefer the name.rs pattern over name/mod.rs :)

Note: I believe we should address the TODO before merging this in!

@hal3e hal3e dismissed stale reviews from digorithm and iqdecay via 09f0bde October 18, 2022 10:35
@hal3e hal3e requested a review from a team October 18, 2022 11:12
iqdecay
iqdecay approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@hal3e hal3e merged commit 2ecc6fa into master Oct 18, 2022
@hal3e hal3e deleted the hal3e/fix-test-stopping branch October 18, 2022 16:49
MujkicA pushed a commit that referenced this pull request Oct 18, 2022
@hal3e @MujkicA
fix: exiting tests (#639)
14afcc5
@hal3e hal3e mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iqdecay iqdecay iqdecay approved these changes

@digorithm digorithm digorithm left review comments

Assignees

@hal3e hal3e

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: cannot ctrl-c running the tests
3 participants
@hal3e @digorithm @iqdecay