Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rustc can't prove Send on futures returned by contract methods #669

Merged
merged 4 commits into from
Nov 9, 2022
Merged

fix: rustc can't prove Send on futures returned by contract methods #669

merged 4 commits into from
Nov 9, 2022

Conversation

Salka1988
Copy link
Member

@Salka1988 Salka1988 commented Nov 2, 2022 •
edited
Loading

description in #648

@Salka1988 Salka1988 self-assigned this Nov 2, 2022
@Salka1988 Salka1988 marked this pull request as draft November 2, 2022 21:13
@Salka1988 Salka1988 linked an issue Nov 2, 2022 that may be closed by this pull request
rustc can't prove Send on futures returned by contract methods #648
Closed
@digorithm
Copy link
Member

Could you write a better title and description for this PR, please? 🙏

@Salka1988 Salka1988 changed the title add test fix: rustc can't prove Send on futures returned by contract methods Nov 2, 2022
@Salka1988 Salka1988 closed this Nov 2, 2022
@Salka1988 Salka1988 reopened this Nov 2, 2022
@Salka1988 Salka1988 marked this pull request as ready for review November 9, 2022 09:55
hal3e
hal3e approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM

@digorithm digorithm added the bug Something isn't working label Nov 9, 2022
digorithm
digorithm approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I love the simplicity of this 😂

@Salka1988 Salka1988 merged commit fd27f86 into master Nov 9, 2022
@Salka1988 Salka1988 deleted the Salka1988/multithreading branch November 9, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm approved these changes

@MujkicA MujkicA MujkicA approved these changes

@hal3e hal3e hal3e approved these changes

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@iqdecay iqdecay Awaiting requested review from iqdecay

Assignees

@Salka1988 Salka1988

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustc can't prove Send on futures returned by contract methods
5 participants
@Salka1988 @digorithm @MujkicA @hal3e @segfault-magnet