feat!: convert client types to fuels types #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MujkicA
changed the title
MujkicA
added
breaking
iqdecay
previously approved these changes
Nov 30, 2022
iqdecay
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #711
The goal of this PR is to introduce an anti-corruption layer between the SDK and fuel-core and to provide a more consistent interface to our users.
It adds the Rust SDK equivalent of types we usually query from the client:
Message,Coin,TransactionResponse,Blocketc.The new types have been applied to
providermethods as a return type and tofuels-test-helpersmethods likesetup_single_asset_coins,setup_single_message.Previously, setup methods would use different types, from those returned by provider methods even though they describe the same data, e.g.
fuel_gql_client::...:: Coinvs. 'fuel_core_interface::...:: Coin'.This also lets us hide
Address(in some cases) in favor ofBech32Addres, ridding us of.into()calls and thereby reducing confusion for the user.