Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-verify flag to publish crate action #79

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

digorithm
Copy link
Member

Our crate publishing step is still blocked by this PR: katyo/publish-crates#394.

However, as shown by katyo (author of publish-crates), one can work around the cyclic deps issue by using the --no-verify flag, which is equivalent to the --no-verify flag in here: https://doc.rust-lang.org/cargo/commands/cargo-publish.html. Here's the concrete example linked by the author: https://github.com/DelSkayn/rquickjs/blob/master/.github/workflows/ci.yml#L349.

This PR enables that in order to try and unblock us for the release of the v0.3.0.

@digorithm digorithm self-assigned this Feb 2, 2022
@digorithm digorithm added the bug Something isn't working label Feb 2, 2022
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. This doesn't make me the most comfortable, but if it works then I guess it works. Can you open an issue to track undoing this when the fix lands upstream?

@digorithm
Copy link
Member Author

Hmm. This doesn't make me the most comfortable, but if it works then I guess it works. Can you open an issue to track undoing this when the fix lands upstream?

Same, not a fan of this at all, what comforts me is that this is only triggered by our CI, which in turn is controlled by the contributors who have access to it.

Still, not ideal and temporary while we wait for @Voxelot's PR on the publish-crates repo. Ah yes, I'll create an issue to undo this asap.

@Voxelot
Copy link
Member

Voxelot commented Feb 3, 2022

It might help to add --dry-run to catch any issues that might come from packaging without relying on crates.io.

@adlerjohn
Copy link
Contributor

--dry-run didn't work for me, because it will fail on missing local dep. Maybe it works when combined with --no-verify, but should be tested in the dummy repo first. https://github.com/FuelLabs/fuel-dummy-test/pull/21

@digorithm digorithm merged commit fbcf434 into master Feb 3, 2022
@digorithm digorithm deleted the rodrigo/fix-circular-dep-crate-publishing branch February 3, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants