You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In another terminal run fuel-core run --db-type in-memory
Run pnpm vitest --run ec-recover
Expected Behavior
In our first test, the transaction was successfully populated with the witness data using the provided lines of code. However, after making a few minor adjustments for the second test, the witness data no longer seems to populate correctly. I'm unsure if this behavior is intentional.
The current naming convention adds to the confusion, leading me to believe that the transaction should automatically populate with .populateTransactionWitnessesSignature(), eliminating the need for further action on my part. Ideally, I'd prefer a more streamlined approach, perhaps integrating the signature and transaction population into a single function specifically in .signTransaction(), utilizing a Last In, First Out (LIFO) stack.
This makes it more intuitive and user-friendly.
Additionally the error message I get is as follows
An issue here is that populateTransactionWitnessesSignature only updates a witness if a coin input belongs to the address doing the signing (I assume this is updating the dummy witness).As above, they may have no inputs, they are just there to sign the transaction, such as that as a multi sig with many signers but one coin input.
What version of fuels-ts are you using?
v0.73.0
Steps to Reproduce
https://github.com/calldelegation/multisig-predicate/tree/report/signing-predicate-txn
report/signing-predicate-txn
branchpnpm install
fuel-core run --db-type in-memory
pnpm vitest --run ec-recover
Expected Behavior
In our first test, the transaction was successfully populated with the witness data using the provided lines of code. However, after making a few minor adjustments for the second test, the witness data no longer seems to populate correctly. I'm unsure if this behavior is intentional.
TEST 1:
transacts using predicate
TEST 2:
transacts using predicate fails
https://github.com/calldelegation/multisig-predicate/blob/report/signing-predicate-txn/frontend/tests/ec-recover.test.ts
The current naming convention adds to the confusion, leading me to believe that the transaction should automatically populate with
.populateTransactionWitnessesSignature()
, eliminating the need for further action on my part. Ideally, I'd prefer a more streamlined approach, perhaps integrating the signature and transaction population into a single function specifically in.signTransaction()
, utilizing a Last In, First Out (LIFO) stack.This makes it more intuitive and user-friendly.
Additionally the error message I get is as follows
This error message is also very misleading. It made me think that there was an error with not the SDK but my predicate when that is not the case.
Actual Behavior
TEST 1:
transacts using predicate
returns
TEST 2:
transacts using predicate fails
returns
cc @danielbate
The text was updated successfully, but these errors were encountered: