Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: improve signing DX #1815

Merged
merged 76 commits into from
Mar 24, 2024
Merged

feat!: improve signing DX #1815

merged 76 commits into from
Mar 24, 2024

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Feb 27, 2024 •
edited
Loading

Closes #1745

  • Implementing signing transaction via an Account through a wallet connector
  • Add multiple external signers to a request through addAccountWitnesses functions on BaseTransactionRequest
  • Rename createWitness to addEmptyWitness and implement addWitness fully
  • Add documentation and example for a script and predicate multi sig with external signers (we only ever used signMessage, I have added signTransaction examples)
  • Improvements and fixes to current docs around signing

Please note, the approach discussed in #1576 has not been implemented here however there is merit to it, as shown in the predicate test example.

@danielbate danielbate added the feat Issue is a feature label Feb 27, 2024
@danielbate danielbate self-assigned this Feb 27, 2024
@danielbate
Merge branch 'master' into db/feat/improve-signing-dx
20961cf
@danielbate
chore: update test values
3ff6fd0
@danielbate
Merge branch 'master' into db/feat/improve-signing-dx
fc02281
@danielbate
Merge branch 'master' into db/feat/improve-signing-dx
5690f59
@danielbate
Merge branch 'master' into db/feat/improve-signing-dx
3f5eabb
@danielbate
feat: add predicate and script signing tests
5c469a4
@danielbate
Merge branch 'db/feat/improve-signing-dx' of https://github.com/FuelL…
db6bab3 
…abs/fuels-ts into db/feat/improve-signing-dx
@danielbate
feat: rename createWitness -> createEmptyWitness
c5b9de5
@danielbate
feat: add signTransaction to wallet connector and update unlocked wal…
85cb07c 
…let function signature
@danielbate
feat: add create witness helper and rename dummy witness helper
7b069e3
@danielbate
chore: remove redundant test
36452f7
@danielbate
feat: add addSigner to base tx request
3ed4770
@danielbate
chore: forc format
b162264
@danielbate
docs: improvements to current signing docs
3b8c91a
@danielbate
docs: add cookbook for multisig
9a467e0
@danielbate
Merge branch 'master' into db/feat/improve-signing-dx
2250a14
@danielbate
feat: add missing sway var in multi sig script test
8874de9
@danielbate
chore: add logs to test
6084fab
@danielbate
feat: rename createWitness -> addWitness
dea9b14
@danielbate
feat: fix the predicate test and reorganise the docs
ba854ef
@danielbate
chore: linting
3717908
@danielbate danielbate marked this pull request as ready for review March 1, 2024 17:21
@danielbate danielbate requested a review from nedsalk March 20, 2024 11:54
nedsalk
nedsalk previously approved these changes Mar 20, 2024
View reviewed changes
arboleya
arboleya previously approved these changes Mar 20, 2024
View reviewed changes
@danielbate danielbate enabled auto-merge (squash) March 20, 2024 16:40
Dhaiwat10
Dhaiwat10 previously approved these changes Mar 20, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024 •
edited by fuel-service-user
Loading

✨ A PR has been created under the rc-1815 tag on fuels-wallet repo.
FuelLabs/fuels-wallet#1174

@Torres-ssf
feat: improve signing dx suggestion (#1926)
4838da7 
* add signatureCallback flag to getTransactionCost

* made BaseInvocationScope supports adding signers

* simplify test case
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
81.35%(-0.11%) 71.84%(-0.14%) 78.98%(-0.17%) 81.46%(-0.1%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 76.51%
(-1.78%)		 53.96%
(-1.77%)		 81.81%
(-3.9%)		 76.51%
(-1.78%)
🔴 packages/account/src/connectors/fuel-connector.ts 25.92%
(-1%)		 100%
(+0%)		 4.76%
(-0.24%)		 25.92%
(-1%)
🔴 packages/account/src/providers/provider.ts 78.14%
(-0.21%)		 64.12%
(-0.44%)		 85.07%
(+0%)		 78.85%
(-0.21%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 85.61%
(+0.61%)		 69.44%
(+0.87%)		 86.27%
(+0.86%)		 85.43%
(+0.61%)

@danielbate danielbate merged commit fabb7a8 into master Mar 24, 2024
15 checks passed
@danielbate danielbate deleted the db/feat/improve-signing-dx branch March 24, 2024 14:00
@fuel-service-user fuel-service-user mentioned this pull request Mar 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@nedsalk nedsalk nedsalk approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

Assignees

@danielbate danielbate

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Populating transaction witnesses signature naming convention
6 participants
@danielbate @Dhaiwat10 @arboleya @petertonysmith94 @nedsalk @Torres-ssf